Skip to content

Revert "fix(docs): load MDX bodies on demand so the Worker fits Cloudflare's 64 MiB limit" - #268

Merged
os-project-manager merged 1 commit into
mainfrom
claude/pm-dispatch-objectos-cw8i2u
Sep 4, 2026
Merged

Revert "fix(docs): load MDX bodies on demand so the Worker fits Cloudflare's 64 MiB limit"#268
os-project-manager merged 1 commit into
mainfrom
claude/pm-dispatch-objectos-cw8i2u

Conversation

@os-project-manager

Copy link
Copy Markdown
Collaborator

Reverts PR #263 (1933e623). Refs #261, #266.

This does not restore the site — the Cloudflare rollback already did that. This removes a landmine that the rollback leaves behind.

Why this is needed after a successful rollback

The rollback put Worker version 69c79ee3-… (2026-08-25) back on 100% of traffic. But main still carried async: true, and deploy-docs.yml fires on apps/docs/**, content/docs/** and pnpm-lock.yaml. The next merge of any docs change would have rebuilt and redeployed the broken version, breaking production again — with nobody expecting it, because the person merging would think they were landing a docs edit.

Reverting restores the pre-incident steady state, which is stable rather than merely quiet:

  • the bundle goes back over Cloudflare's 64 MiB limit
  • deploys are therefore rejected at version creation
  • a rejected upload changes nothing, so 69c79ee3-… keeps serving

So the site stays up on the known-good version, and no future merge can silently replace it. Stale, working, and safe to leave alone — where it was for the 10 days before I touched it.

⚠️ Merging this fires a deploy that will fail, and that failure is the intended outcome, not a regression to chase. It is the same rejection that ran 36 times between 2026-08-25 and today.

What this does to #261

#261 goes back to being open and unfixed — the docs site cannot publish. That is the honest state. The fix in #263 was correct about the cause (the corpus was inlined once per server entrypoint, five times over) and its mechanism was verified under real workerd; what was never verified was whether a docs page renders, because those routes 404 in local preview on main too (#265).

So the order of work was wrong, and reinstating the fix should follow the corrected order:

  1. Prerendered docs page routes 404 under local wrangler dev / opennextjs-cloudflare preview, so no page can be smoke-tested in the Workers runtime before merge #265 first — make it possible to load a real docs page in the Workers runtime before merge.
  2. Every merge to main publishes the production docs site with no human gate — the cloudflare-docs environment has no required reviewer #266 — a human gate on the deploy, so no agent can publish by merging.
  3. Only then re-land the async: true change, verified against a rendered page rather than against an accepted upload.

Deviations, stated

  • Authored by the PM seat rather than a dispatched dev, during an active incident, on the maintainer's direct instruction to roll back. Same deviation already flagged on ci(docs): add a manual Cloudflare rollback workflow #267.
  • Created via git revert -m 1 of the merge commit rather than hand-edited: 2 files, +2/−29, no judgement applied.

🤖 Generated with Claude Code

https://claude.ai/code/session_01GkauAsZBEemRbco2rEX9Lx


Generated by Claude Code

…docs-deploy-worker-size"

This reverts commit 1933e62, reversing
changes made to 896efd1.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants